Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logout not working #3368

Closed
SzymonKlimuk opened this issue Jul 11, 2017 · 7 comments
Closed

logout not working #3368

SzymonKlimuk opened this issue Jul 11, 2017 · 7 comments

Comments

@SzymonKlimuk
Copy link

SzymonKlimuk commented Jul 11, 2017

  • swagger-ui version 3.0.17

Hi, We are testing the Swagger UI vs keycloak authentication.

Assuming successful authentication (any flow: password, accessCode, implicit, application), there is a possibility - the button - to logout. Unfortunately, we see no network traffic after clicking on this button.

I understand that click action probably clears some js variables in swagger ui, but shall it cause any logout action on the keycloak?

Is it not implemented yet?

Are you going to implement it?

Regards,

Szymon Klimuk

@shockey
Copy link
Contributor

shockey commented Jul 13, 2017

@SzymonKlimuk, you're correct - clicking Logout simply flushes the authorization information the Swagger-UI stores internally.

I'm not familiar with keycloak, but it appears to be an identity management tool. Swagger-UI doesn't directly integrate with keycloak (or any other specific identity management tool).

You can write your own plugin for Swagger-UI that integrates with keycloak to solve your specific use case if you'd like.

@Fredx87
Copy link

Fredx87 commented Jul 17, 2017

Keycloak is an open source identity and access management tool. It uses standard protocols such as OAuth2 and OpenID Connect to manage authentication and authorization.

I think that it is correct that Swagger UI doesn't implement the logout call to keycloak at the moment, because the logout URL is not specified in the Open API 2.0 spec. Open API 3.0 will support OpenID Connect, and then I think that the logout process should be taken into account by Swagger UI.

Anyway I've have written a simple plugin that calls the logout page of Keycloak when the user press the Logout button, you can find it here: https://gist.github.com/Fredx87/48fe741eed42efa4e77bd341745084a8

@shockey
Copy link
Contributor

shockey commented Jul 17, 2017

@Fredx87 thanks for sharing that plugin!

We're tracking OAS 3.0 Try-It-Out support in #3338, which should include OpenID Connect support. We haven't sketched out the finer points of that yet, so I can't definitively say what will be supported and what won't be - but if OpenID Connect session management is a big thing, I'd expect we build out support for it.

@webron, can you shed some more light on the intentions here with OpenID?

@webron
Copy link
Contributor

webron commented Jul 20, 2017

OIDC is fairly new and not widely used yet. I can't tell right now what from it will be implemented or when.

@shockey
Copy link
Contributor

shockey commented Jul 26, 2017

Closing due to inactivity.

This is simply to keep our issue tracker clean - feel free to comment if there are any further thoughts or concerns, and we'll be happy to reopen this issue.

@shockey shockey closed this as completed Jul 26, 2017
@pthibodeaux
Copy link

Could someone point me to a resource or document to help with how to write a plugin and utilize it within a .net Core application. We are having a similar issue with Identity Server authentication. The logout button only partially clears the Auth information, but does not actually call a Logout process. a subsequent Logon click will reuse the token that it finds and not take the user to the Login Screen,
We would like to call our Identity Server Logout api to logout the user.

@shockey
Copy link
Contributor

shockey commented Dec 19, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants