Model Schema only resolves first of multiple properties with same model

[joernesdohr]

Hi,
I'm writing some custom models for my API. I have a Colour_pure_and_tinted model, which holds 2 properties of the model "Colour", each is the representation of either unaltered pure RGB values or manipulated ones:

        "Colour_pure_and_tinted" : {
            "id" : "Colour_pure_and_tinted",
            "properties" : {
                 "pure"   : { "type" : "Colour", "required" : true }
                ,"tinted" : { "type" : "Colour", "required" : true }
            }
        }

        ,"Colour" : {
            "id" : "Colour",
            "properties" : {
                 "red"   : { "type" : "int", "required" : true }
                ,"green" : { "type" : "int", "required" : true }
                ,"blue"  : { "type" : "int", "required" : true }
            }
        }

But in the Model Schema view, only the very first instance of Colour (property "pure") is resolved to its proper atomic properties representation. "tinted" remains as just "Colour":

        {
            "pure": {
                "red": "int",
                "green": "int",
                "blue": "int"
            },
            "tinted": "Colour"
        }

Am I doing something incorrectly or is this a bug?

[fehguy]

that looks like a bug from what you posted. As a test, can you change tinted to be Colour1 and copy the Colour model appropriately?

[joernesdohr]

tinted resolves correctly to the internal structure of Colour1 then, as does pure to Colour. As expected though, any additional Colour1 property is not resolved.

[fehguy]

OK, sounds like the schema view is only allowing a single instance of an object. I can see cases for and against that behavior but here, it seems to be doing the wrong thing

[rage-shadowman]

I was under the impression that this change was done to avoid infinite recursion (where Model X contains an X in a property).

The fix is a 1-liner in swagger.js file.

See: https://github.com/rage-shadowman/swagger-js/commit/6616a58f1e1e8c516d3921005464f7adf31d7673

Note: The only file that really changed in the above was swagger.coffee, the rest of the changes were because I am using a different version of the node coffee compiler.

[fehguy]

this is pushed to master.