public/swagger/swagger-ui.js does not do a null check

[kktiwa]

There should be null check for 'definitions' without which the Swagger UI fails to load.

Line number 3468
Existing Code:

if (definitions[ref]) {
return new Model(ref, definitions[ref], this.models);

Code changed as fix:

if (definitions && definitions[ref]) {
return new Model(ref, definitions[ref], this.models, this.parent.modelPropertyMacro);

[fehguy]

How are you getting definitions to be null?

[kktiwa]

I am using Swagger in a Play 2.3.7 project and had annotations over one of the REST APIs in my codebase.Inspite of the annotations being present,the swagger URL used to load with definitions being null.

[ponelat]

more like undefined I think?
I've got it once or twice myself, with erroneous specs. However in the feature/yaml we're working on, I've made provision enforcing the spec to at least be an object. Which I believe is the root of this.

I can try to recreate this.

[webron]

@kktiwa - can you share your Swagger definition to help us investigate it?

[webron]

Closing due to lack of activity. Please reopen if needed.