-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(http): replace qs usage by URLSearchParams #3634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me 🎉
do you ever deal with dates in these params? might be worth having an extra else if
specifically for dates, to toISOString()
them (i seem to remember qs doing something like this)
@43081j great tip. Added the ifelse branch for Date. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🎉 This PR is included in version 3.29.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Refs #3606
Refs #3585