Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(http): replace qs usage by URLSearchParams #3634

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Conversation

char0n
Copy link
Member

@char0n char0n commented Aug 11, 2024

Refs #3606
Refs #3585

Copy link

@43081j 43081j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 🎉

do you ever deal with dates in these params? might be worth having an extra else if specifically for dates, to toISOString() them (i seem to remember qs doing something like this)

@char0n
Copy link
Member Author

char0n commented Aug 12, 2024

@43081j great tip. Added the ifelse branch for Date. Thanks!

Copy link
Contributor

@glowcloud glowcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@char0n char0n merged commit b8fa2d4 into master Aug 12, 2024
7 checks passed
@char0n char0n deleted the char0n/qs-removal branch August 12, 2024 08:22
@swagger-bot
Copy link
Contributor

🎉 This PR is included in version 3.29.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants