Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript-angular] Broken uploads since updating to 3.0.14 #553

Closed
louisl opened this issue Dec 4, 2019 · 3 comments
Closed

[typescript-angular] Broken uploads since updating to 3.0.14 #553

louisl opened this issue Dec 4, 2019 · 3 comments
Assignees
Milestone

Comments

@louisl
Copy link

louisl commented Dec 4, 2019

I think something broke with this PR #526, It fixed some issues where I had to manually fix stuff but now I'm getting this,

return this.httpClient.post<StorageObject>(`${this.basePath}/storage-objects/${encodeURIComponent(String(storageObjectId))}/upload`,
            {
                withCredentials: this.configuration.withCredentials,
                headers: headers,
                observe: observe,
                reportProgress: reportProgress
            }
        );

instead of this,

return this.httpClient.post<StorageObject>(`${this.basePath}/storage-objects/${encodeURIComponent(String(storageObjectId))}/upload`,
           // The line below is now missing.
            convertFormParamsToString ? formParams.toString() : formParams, 
            {
                withCredentials: this.configuration.withCredentials,
                headers: headers,
                observe: observe,
                reportProgress: reportProgress
            }
        );
@louisl
Copy link
Author

louisl commented Dec 4, 2019

Also mentioned here swagger-api/swagger-codegen#9890, not sure why he closed it though

@cmalard
Copy link
Contributor

cmalard commented Jan 9, 2020

Hey @louisl , 3.0.16 is not functionnal (fixed in #576) but can you test it to check if body param is back ?

@HugoMario HugoMario self-assigned this May 2, 2020
@HugoMario HugoMario added this to the M1 milestone May 2, 2020
@HugoMario
Copy link
Contributor

tested and confirm this is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants