This repository has been archived by the owner on May 24, 2022. It is now read-only.
Handle prefix removal when entire path is removed #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The req_path action allows for removing the entire matched path, which could lead to an empty "path" variable in Varnish. This did not render the config invalid but caused a 503 to be thrown when the rule was triggered. The config template now includes a check for an empty path variable and handles the case correctly.
ghost
requested a review
from 
ghost
linked an issue
splushii
suggested changes
Jun 12, 2020
|
Oh, regarding the pip 20 issue. Saw now that pip |
I say we make a new issue for this. |
splushii
approved these changes
Jun 16, 2020
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The req_path action allows for removing the entire matched path,
which could lead to an empty "path" variable in Varnish. This
did not render the config invalid but caused a 503 to be thrown
when the rule was triggered. The config template now includes a
check for an empty path variable and handles the case correctly.
Resolves #37