Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRY mailing views #336

Open
cdfa opened this issue Mar 9, 2018 · 2 comments
Open

DRY mailing views #336

cdfa opened this issue Mar 9, 2018 · 2 comments
Labels

Comments

@cdfa
Copy link
Contributor

cdfa commented Mar 9, 2018

The mailing view contain a lot of duplicated code for the table layouts (especially the inline styles). This has a bad impact on readability and maintainablity. We should DRY it up a little.

@martijncasteel
Copy link
Collaborator

Keep in mind, that mail clients are quite strict in using css and tables in mails.

@cdfa
Copy link
Contributor Author

cdfa commented Mar 9, 2018

I know, but as long as we use templating is should be fine I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants