Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add plublic events #90

Merged
merged 1 commit into from
Sep 18, 2019
Merged

feat: add plublic events #90

merged 1 commit into from
Sep 18, 2019

Conversation

leeluolee
Copy link
Contributor

cherry-pick commit from public-api-fix

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the related issue? (Use #issue_id to relate an open issue)

  • Does this PR introduce a breaking change?

  • Other information:

@codecov
Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #90 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #90      +/-   ##
=========================================
+ Coverage   91.89%   91.9%   +0.01%     
=========================================
  Files          44      44              
  Lines        1566    1568       +2     
=========================================
+ Hits         1439    1441       +2     
  Misses        127     127
Impacted Files Coverage Δ
packages/svrx/lib/svrx.js 95.09% <100%> (+0.09%) ⬆️
packages/svrx/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b84f05c...557e40e. Read the comment docs.

@xuchaoying xuchaoying merged commit 335c2b1 into master Sep 18, 2019
@xuchaoying xuchaoying deleted the pubic-fix-events branch September 18, 2019 05:58
@xuchaoying xuchaoying added the PR: new feature :rocket: New Feature label Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: new feature :rocket: New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants