Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config.get() to get all default values #22

Merged
merged 5 commits into from
Jul 30, 2019
Merged

Fix config.get() to get all default values #22

merged 5 commits into from
Jul 30, 2019

Conversation

xuchaoying
Copy link
Member

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

bugfix

  • What is the related issue? (Use #issue_id to relate an open issue)

  • Does this PR introduce a breaking change?

  • Other information:

@xuchaoying xuchaoying self-assigned this Jul 30, 2019
@xuchaoying xuchaoying added the PR: bug fix :bug: Bug Fix label Jul 30, 2019
@xuchaoying xuchaoying requested a review from a team July 30, 2019 03:24
@xuchaoying xuchaoying marked this pull request as ready for review July 30, 2019 08:51
@xuchaoying xuchaoying merged commit 602ef9d into master Jul 30, 2019
@xuchaoying xuchaoying deleted the cy-fix-config-get branch July 30, 2019 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leeluolee leeluolee leeluolee approved these changes

Assignees

@xuchaoying xuchaoying

Labels
PR: bug fix :bug: Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuchaoying @leeluolee