Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix process exit not working on Windows #132

Merged
merged 4 commits into from
Oct 24, 2019
Merged

Fix process exit not working on Windows #132

merged 4 commits into from
Oct 24, 2019

Conversation

xuchaoying
Copy link
Member

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

bug fix

  • What is the related issue? (Use #issue_id to relate an open issue)

#127

  • Does this PR introduce a breaking change?

no

  • Other information:

@xuchaoying xuchaoying requested a review from a team October 24, 2019 05:47
@xuchaoying xuchaoying added the PR: bug fix :bug: Bug Fix label Oct 24, 2019
@xuchaoying xuchaoying added this to the v1.0.5 milestone Oct 24, 2019
@codecov
Copy link

codecov bot commented Oct 24, 2019

Codecov Report

Merging #132 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
+ Coverage   92.18%   92.21%   +0.02%     
==========================================
  Files          44       44              
  Lines        1599     1605       +6     
==========================================
+ Hits         1474     1480       +6     
  Misses        125      125
Impacted Files Coverage Δ
packages/svrx/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8fc920...cf4552b. Read the comment docs.

@xuchaoying xuchaoying merged commit 69ff38e into master Oct 24, 2019
@xuchaoying xuchaoying deleted the cy-force-stop branch October 24, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix :bug: Bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants