Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the duplicated spans in the otel logging #714

Open
tasn opened this issue Nov 29, 2022 · 2 comments
Open

Remove the duplicated spans in the otel logging #714

tasn opened this issue Nov 29, 2022 · 2 comments
Labels
server Issues regarding the server component

Comments

@tasn
Copy link
Member

tasn commented Nov 29, 2022

All of the logs are duplicated and show both under span and under spans. This is unnecessary and wasteful, we can just keep spans.

We just need to verify that spans.0 is always equivalent to span, because if the ordering is reversed it would suck a bit (because it'll be hard to know the top level).

What's the common way of doing it?

@tasn tasn added the server Issues regarding the server component label Nov 29, 2022
@tasn
Copy link
Member Author

tasn commented Dec 19, 2022

Speak with @svix-james too, maybe it's not wanted/needed, though I think it is?

@swarna1101

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server Issues regarding the server component
Projects
None yet
Development

No branches or pull requests

3 participants