Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] delete event-type does not delete anything #1457

Closed
michabbb opened this issue Sep 28, 2024 · 5 comments · Fixed by #1467
Closed

[server] delete event-type does not delete anything #1457

michabbb opened this issue Sep 28, 2024 · 5 comments · Fixed by #1467
Assignees
Labels
server Issues regarding the server component

Comments

@michabbb
Copy link

Bug Report

docker: svix/svix-server:v1.36.0

call: DELETE http://xxxxxxxxx:8071//api/v1/event-type/order.delivered/?expunge=true
response: 204

but a list event-types always shows:

{
    "data": [
        {
            "name": "item.delivered",
            "description": "an item has been deliverd",
            "archived": false,
            "deprecated": false,
            "schemas": null,
            "createdAt": "2024-09-28T19:43:38.872620Z",
            "updatedAt": "2024-09-28T19:43:38.872620Z",
            "featureFlag": null
        },
        {
            "name": "order.delivered",
            "description": "an order has been deliverd",
            "archived": true,
            "deprecated": false,
            "schemas": null,
            "createdAt": "2024-09-28T18:01:01.953404Z",
            "updatedAt": "2024-09-28T20:08:19.369679Z",
            "featureFlag": null
        }
    ],
    "iterator": "order.delivered",
    "prevIterator": "-item.delivered",
    "done": true
}

so whatever I do, I cannot delete the "order.delivered" event-type 😢
please let me know if I am doing something wrong.

thanks!

@tasn
Copy link
Member

tasn commented Sep 28, 2024

It changes it to "archived". You need to pass expunge in order to fully remove it: https://api.svix.com/docs#tag/Event-Type/operation/v1.event-type.delete

@tasn tasn closed this as completed Sep 28, 2024
@michabbb
Copy link
Author

@tasn

image

is that wrong ????

@tasn tasn added the server Issues regarding the server component label Sep 28, 2024
@tasn tasn reopened this Sep 28, 2024
@tasn
Copy link
Member

tasn commented Sep 28, 2024

I missed that. It looks like another feature that was built in SaaS but hasn't been backported to OSS.

@michabbb
Copy link
Author

@tasn so... is it save to delete it directly in the database ? or are there any dependencies ??

@tasn
Copy link
Member

tasn commented Sep 28, 2024

You can delete it in the database, it shouldn't be a problem. Though we'll also fix it first thing next week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server Issues regarding the server component
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants