Libs(Go): add convenience constructor for static nullable strings #1497
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1198
While this isn't quite the type of change that was requested in #1198, I'm hopeful it'll reduce a bit of the friction.
A new constructor is now available as
svix.StaticNullableString()
which gives anopenapi.NullableString
.Note that the return type (not a pointer) is inconsistent with the rest of the functions that act as primative constructors, and in fact goes against the convention of constructors returning pointers to the value they initialize.
The issue was raised, however, that all the places in the lib where a
NullableString
is needed, we'd have to dereference it anyway.Since this alt constructor is all about convenience, we may as well break convention. In for a penny, in for a pound...
The net effect is instead of:
folks will now be able to write: