Skip to content
This repository has been archived by the owner on Dec 3, 2022. It is now read-only.

typescript 2.4.1 cannot resolve modules #8

Closed
iwllyu opened this issue Jul 7, 2017 · 3 comments
Closed

typescript 2.4.1 cannot resolve modules #8

iwllyu opened this issue Jul 7, 2017 · 3 comments

Comments

@iwllyu
Copy link

iwllyu commented Jul 7, 2017

with typescript 2.4.1 there was a breaking change to ts-node. ts-node now fails to find any @types navigation files

microsoft/TypeScript#16772 (comment)

this is fixed in ts-node v3.1.0

I'm not sure how feasible this is but I know serverless-webpack made webpack a peer dependency, making it so the user can use an arbitrary version of webpack with serverless-webpack. Can we do something similar with jasmine-ts?

@iwllyu
Copy link
Author

iwllyu commented Jul 10, 2017

or we could just bump the ts-node version

@antoniusostermann
Copy link

+1

@svi3c svi3c mentioned this issue Jul 13, 2017
@svi3c
Copy link
Owner

svi3c commented Jul 13, 2017

Hi @iwllyu,

When we use peer dependencies, every consumer of this library would be forced to install another dependency (ts-node) to get this tool running. Also the versions have to be kept compatible on each consuming package configuration.
I'm not sure whether this is desirable, since you don't necessarily want to use ts-node directly within your package.

For now I just updated the package versions.

@svi3c svi3c closed this as completed in #9 Jul 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants