Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint details missing #1435

Closed
strarsis opened this issue Mar 19, 2021 · 4 comments
Closed

Lint details missing #1435

strarsis opened this issue Mar 19, 2021 · 4 comments
Labels

Comments

@strarsis
Copy link
Contributor

Describe the bug
Currently the lint script lists only the files with linting issues, no further details about the specific lint rule or the line.

To Reproduce
Steps to reproduce the behavior:

  1. Introduce a lint error in a file in svgo.
  2. Run the lint script (npm run lint).
    Notice that the lint fails with nonzero exit code and the file path logged,
    but no further indications are made about the lint rule or the exact line.

Expected behavior
A detailed lint report so it is easy to fix the linting issues.

Desktop (please complete the following information):

  • SVGO Version: master
  • NodeJs Version: v14.16.0
  • OS: WSL 2
@strarsis strarsis added the bug label Mar 19, 2021
@TrySound
Copy link
Member

Do you mean this? It's prettier error.

$ eslint . && prettier --list-different "**/*.js" --ignore-path .gitignore
lib/svgo/jsAPI.js
error Command failed with exit code 1.

@strarsis
Copy link
Contributor Author

strarsis commented Mar 19, 2021

@TrySound: So the prettier itself has an issue?
Currently the builds for two of my PRs are failing because npm run lint fails.
When I invoke npm run lint I see the plugin file listed, but not what line or what the linter doesn't like about it.
#1381
#1279

@TrySound
Copy link
Member

Not issue. Just format the file with it.

@TrySound
Copy link
Member

Added "fix" script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants