From a32d26e9addaeda773330e827182e555ac6d7da0 Mon Sep 17 00:00:00 2001
From: Seth Falco <seth@falco.fun>
Date: Thu, 5 Oct 2023 19:22:45 +0100
Subject: [PATCH] fix(removeScriptElement): remove link anchors with scripts

---
 README.md                               |  2 +-
 plugins/removeScriptElement.js          | 30 +++++++++++++++++++++++--
 test/plugins/removeScriptElement.02.svg | 15 +++++++++++++
 test/plugins/removeScriptElement.03.svg | 17 ++++++++++++++
 4 files changed, 61 insertions(+), 3 deletions(-)
 create mode 100644 test/plugins/removeScriptElement.02.svg
 create mode 100644 test/plugins/removeScriptElement.03.svg

diff --git a/README.md b/README.md
index 4296cae1e..64f8aa854 100644
--- a/README.md
+++ b/README.md
@@ -198,7 +198,7 @@ const config = await loadConfig(configFile, cwd);
 | [removeNonInheritableGroupAttrs](https://github.com/svg/svgo/blob/main/plugins/removeNonInheritableGroupAttrs.js) | remove non-inheritable group's "presentation" attributes                                                                                                 | Yes     |
 | [removeOffCanvasPaths](https://github.com/svg/svgo/blob/main/plugins/removeOffCanvasPaths.js)                     | removes elements that are drawn outside of the viewbox                                                                                                   |         |
 | [removeRasterImages](https://github.com/svg/svgo/blob/main/plugins/removeRasterImages.js)                         | remove raster images                                                                                                                                     |         |
-| [removeScriptElement](https://github.com/svg/svgo/blob/main/plugins/removeScriptElement.js)                       | remove `<script>` elements                                                                                                                               |         |
+| [removeScriptElement](https://github.com/svg/svgo/blob/main/plugins/removeScriptElement.js)                       | remove scripts                                                                                                                                 |         |
 | [removeStyleElement](https://github.com/svg/svgo/blob/main/plugins/removeStyleElement.js)                         | remove `<style>` elements                                                                                                                                |         |
 | [removeTitle](https://github.com/svg/svgo/blob/main/plugins/removeTitle.js)                                       | remove `<title>`                                                                                                                                         | Yes     |
 | [removeUnknownsAndDefaults](https://github.com/svg/svgo/blob/main/plugins/removeUnknownsAndDefaults.js)           | remove unknown elements content and attributes, remove attributes with default values                                                                    | Yes     |
diff --git a/plugins/removeScriptElement.js b/plugins/removeScriptElement.js
index 0e42de4c5..21cb22192 100644
--- a/plugins/removeScriptElement.js
+++ b/plugins/removeScriptElement.js
@@ -3,10 +3,10 @@
 const { detachNodeFromParent } = require('../lib/xast.js');
 
 exports.name = 'removeScriptElement';
-exports.description = 'removes <script> elements (disabled by default)';
+exports.description = 'removes scripts (disabled by default)';
 
 /**
- * Remove <script>.
+ * Remove scripts.
  *
  * https://www.w3.org/TR/SVG11/script.html
  *
@@ -20,6 +20,32 @@ exports.fn = () => {
       enter: (node, parentNode) => {
         if (node.name === 'script') {
           detachNodeFromParent(node, parentNode);
+          return;
+        }
+
+        if (node.name === 'a') {
+          for (const attr of ['href', 'xlink:href']) {
+            if (
+              node.attributes[attr] == null ||
+              !node.attributes[attr].trimStart().startsWith('javascript:')
+            ) {
+              continue;
+            }
+
+            detachNodeFromParent(node, parentNode);
+            const index = parentNode.children.indexOf(node);
+            parentNode.children.splice(index, 1, ...node.children);
+
+            // TODO remove legacy parentNode in v4
+            for (const child of node.children) {
+              Object.defineProperty(child, 'parentNode', {
+                writable: true,
+                value: parentNode,
+              });
+            }
+
+            return;
+          }
         }
       },
     },
diff --git a/test/plugins/removeScriptElement.02.svg b/test/plugins/removeScriptElement.02.svg
new file mode 100644
index 000000000..d67891fca
--- /dev/null
+++ b/test/plugins/removeScriptElement.02.svg
@@ -0,0 +1,15 @@
+Removes link to JavaScript function.
+
+===
+
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 100 100">
+  <a href="javascript:(() => { alert('uwu') })();">
+    <text y="10">uwu</text>
+  </a>
+</svg>
+
+@@@
+
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 100 100">
+    <text y="10">uwu</text>
+</svg>
diff --git a/test/plugins/removeScriptElement.03.svg b/test/plugins/removeScriptElement.03.svg
new file mode 100644
index 000000000..72a767ef3
--- /dev/null
+++ b/test/plugins/removeScriptElement.03.svg
@@ -0,0 +1,17 @@
+Does not remove normal links.
+
+===
+
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 100 100">
+  <a href="https://yewtu.be/watch?v=dQw4w9WgXcQ">
+    <text y="10">uwu</text>
+  </a>
+</svg>
+
+@@@
+
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 100 100">
+    <a href="https://yewtu.be/watch?v=dQw4w9WgXcQ">
+        <text y="10">uwu</text>
+    </a>
+</svg>