Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github action fails #203

Closed
srbhp opened this issue Oct 7, 2023 · 4 comments
Closed

Github action fails #203

srbhp opened this issue Oct 7, 2023 · 4 comments

Comments

@srbhp
Copy link

srbhp commented Oct 7, 2023

Local builds works perfectly fine.
But GitHub action fails of my project https://github.com/srbhp/nrgplusplus.
Is anyone else having this issues? It used to fine.

/home/runner/.local/lib/python3.10/site-packages/breathe/project.py:116: RemovedInSphinx80Warning: Sphinx 8 will drop support for representing paths as strings. Use "pathlib.Path" or "os.fspath" instead.
  self._default_build_dir = os.path.dirname(app.doctreedir.rstrip(os.sep))
making output directory... done
/home/runner/.local/lib/python3.10/site-packages/exhale/configs.py:1408: RemovedInSphinx80Warning: Sphinx 8 will drop support for representing paths as strings. Use "pathlib.Path" or "os.fspath" instead.
  _one     = containmentFolder == app.srcdir

Extension error (exhale):
Handler <function environment_ready at 0x7f8bea878700> for event 'builder-inited' threw an exception (exception: startswith first arg must be str or a tuple of str, not _StrPath)
gmake[2]: *** [docs/CMakeFiles/Sphinx.dir/build.make:75: docs/sphinx/index.html] Error 2
gmake[1]: *** [CMakeFiles/Makefile2:170: docs/CMakeFiles/Sphinx.dir/all] Error 2
gmake: *** [Makefile:136: all] Error 2
@svenevs
Copy link
Owner

svenevs commented Oct 7, 2023

Looks like you might have put a Path object in conf.py to exhale_args. Needs to be a string most likely. I can relax that in the future

@Rotzbua
Copy link
Contributor

Rotzbua commented Oct 20, 2023

This is a problem with breathe. It is incompatible with sphinx 7.2.
May be solved by breathe-doc/breathe#956 .

@svenevs
Copy link
Owner

svenevs commented Oct 22, 2023

This is a problem with breathe. It is incompatible with sphinx 7.2.

Thanks for the information! So we're in a weird place with dependencies, #205 is trying to make things less restrictive. The reason: this project does not update frequently, and over time the restrictions proved pointless and also impeded users.

My rationale for that PR is that I do not want to prevent say, 3 months from now, when a newer version of breathe is out and works with sphinx 7.2+ (as an example), but exhale started forcing sphinx<7.2. It's a bit of a hand-waive, but the API between exhale and breathe does not change (or at least I hope it doesn't...).

@srbhp the way to fix this would be to make sure that you install both sphinx and breathe before exhale. For example, if you are using a requirements.txt, you might do something like

sphinx==7.1
breathe
exhale

or something similar. If that works for you then I will make sure to add some notes to the compatibility table explaining what this release will do in terms of version requirements, and the fact that I'm pushing some of this responsibility onto users now (so that I don't gridlock them down the road).

I'm very open to thoughts, but this repo is very much in "emergency maintenance only" mode...so I'm really looking for the solution that fits "does not completely break everybody" but also "makes less maintenance overhead for exhale".

@svenevs
Copy link
Owner

svenevs commented Jan 28, 2024

This was likely fixed by the latest release

@svenevs svenevs closed this as completed Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants