-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Appveyor's configuration #2991
Conversation
This seems good for now, but it might be nice sometime to switch to Travis's multi-OS builds and get rid of Appveyor. |
Huh https://ci.appveyor.com/project/Rich-Harris/svelte/builds/25155137/job/2fquajgk0kt579hj I don't know what to make of that. |
appveyor/ci#2921 hasn't been fixed yet. |
Eek. Used the |
- ps: Install-Product node $env:nodejs_version | ||
- npm install | ||
- ps: Update-NodeJsInstallation (Get-NodeJsLatestBuild $env:nodejs_version) | ||
- npm ci || npm install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this || npm install
fallback is not needed, because npm CLI update was backported to Node.js 8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL!
Huh. After over a month v12 still isn't available in the standard way? Maybe this is another reason to move to Travis for this sooner rather than later. |
How straightforward is it to get things up and running on Travis? |
Here's the config I used for cheap-watch, and everything Just Worked. Although I'm realizing now that I'm not sure how this would deal with the custom element tests in puppeteer. |
Do your Windows tests on Travis also work on free accounts?
I'm using puppeteer on the tests of my library |
I'm using a Windows build on Travis in the project I linked to in my previous comment, and I'm not paying them. |
Wow. Good to know! |
Follow up to #2970, also make sure we support node v8+ on Windows.