Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Premature update trigger? #710

Closed
dxlbnl opened this issue Jul 11, 2017 · 5 comments
Closed

Premature update trigger? #710

dxlbnl opened this issue Jul 11, 2017 · 5 comments

Comments

@dxlbnl
Copy link
Contributor

dxlbnl commented Jul 11, 2017

I think I've hit a bug introduced in 1.22 -> 1.23.
where update is called on a fragment before create was called.

I'm not entirely sure how and when this bug is triggered. But here's a stacktrace. It's quite a big app.

setAttribute (shared.js?7218:66)
update (Pop.svg?d418:5)
_set (Pop.svg?d418:98)
(anonymous) (Pop.svg?d418:93)
observe (shared.js?7218:340)
(anonymous) (Pop.svg?d418:90)
Pop (Pop.svg?d418:98)
create_main_fragment (Editor.html:5)
Editor (Editor.html:74)
(anonymous) (editor.js:20)

in setAttribute node is undefined, which (with a quick look) and a debugger statement, brings me that update is being called before create is, on the fragment.

@PaulBGD
Copy link
Member

PaulBGD commented Jul 11, 2017

Do you think you could create a small reproduction? It's hard to know what could be happening here since the issue could be relating to multiple nested components, yield blocks, and/or other 3rd party code.

@Rich-Harris
Copy link
Member

This might be fixed in the most recent versions, as it sounds related to e.g. #708. @neoel what happens if you upgrade?

@Rich-Harris
Copy link
Member

@neoel if you get a chance, can you let us know if this issue can be closed? thanks

@Rich-Harris
Copy link
Member

Closing this as it's probably fixed — let us know if otherwise

@ludwigschubert
Copy link

Not OP, but a separate data point supporting closing:

We definitely ran into this (with very similar stacktrace) after 1.23. We do not experience it anymore with versions 1.3x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants