-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InputOutputToggle doesn't completely hide the browser checkbox #5116
Comments
@Conduitry I don't quite understand why the issue was moved. I thought that the bug is related to https://github.com/sveltejs/svelte/blob/master/site/src/components/Repl/InputOutputToggle.svelte which is located in the main sveltejs repo. Is it planned to move that component to this repo as well? |
Whoops! You are right. I will transfer this back. |
I made a PR in site-kit. |
Could this be updated to has PR? |
Aha, I was trying to fix this issue but it was already fixed here. I swore I saw a fix but couldn't find it. In my solution I am simply adding |
Anything else on my end to get this PR to the finish line? |
Redeployed the site with @benschac's fix 🍻 |
Describe the bug
The
InputOutputToggle
component doesn't completely hide the browser checkbox on mobile safari, there are still parts of the checkbox that are visible which results inInputOutputToggle
looking weird. The rectangle is only visible when the checkbox in its off state.Version:
AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1.1 Mobile/15E148 Safari/604.1
The text was updated successfully, but these errors were encountered: