Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would you like some webpack'y help? #36

Closed
TheLarkInn opened this issue Nov 29, 2016 · 8 comments
Closed

Would you like some webpack'y help? #36

TheLarkInn opened this issue Nov 29, 2016 · 8 comments

Comments

@TheLarkInn
Copy link

Hey @Rich-Harris!!!

This looks pretty neat, I noticed general output from the REPL was globally stuff. I haven't dove deep enough to learn more about svelte (maybe I should). Regardless, I'm sure you will have at least a few requests for webpack'y things, so we are devoted to helping you out in those regards. Let me know if we can be of assistance (if even needed).

@TheLarkInn
Copy link
Author

This could also serve as a collection of ideas/features that could be leveraged. (IE vue has .vue templates for webpack etc. does a .svelte template defeat the simplicity purpose?, etc)

@Rich-Harris
Copy link
Member

Thanks for the offer!

There definitely needs to be a svelte-loader plugin, I was going to get round to it eventually but I'd love some help on that front. It's pretty straightforward, the equivalent Rollup plugin is here – the compiler can generate ES modules or AMD, CJS, IIFE, UMD, so it should have everything we need out-of-the-box.

Want me to create a sveltejs/svelte-loader repo and add you as an admin?

Re .vue – I started out with .svelte files instead but I settled on .html as the preferred extension instead (though the Rollup plugin accepts either). It's just easier to get syntax highlighting and linting that way, no fussing around – and it's not just your editor, it's sourcemaps in your devtools as well. We've been doing that for years with Ractive .html components, and it works well.

@TheLarkInn
Copy link
Author

Want me to create a sveltejs/svelte-loader repo and add you as an admin?

Yes! Although it may not be a immediate implementation at least it's an official medium that I can even enlist a few folks already interested in implementing as well. If you already have a rollup plugin, like you said, it should be pretty straight forward.

It's pretty straightforward, the equivalent Rollup plugin is here – the compiler can generate ES modules or AMD, CJS, IIFE, UMD, so it should have everything we need out-of-the-box.

Awesome, I'll check the plugin! Looking forward to help with this.

@Rich-Harris
Copy link
Member

Youdaman! Here's the repo, have sent you an invite: https://github.com/sveltejs/svelte-loader

No worries if it doesn't happen straight away, as I say it's on my TODO list anyway – I've just never written a Webpack loader before so it might take me a while 😀

@TheLarkInn
Copy link
Author

No sweatsky. Learning opportunity ftw!

@nikku
Copy link
Contributor

nikku commented Dec 5, 2016

I created nikku/svelte-loader and would be happy to contribute it.

@nikku
Copy link
Contributor

nikku commented Dec 7, 2016

We got svelte-loader released now. This issue can be closed.

@TheLarkInn
Copy link
Author

Awesome work guys!!! 👏🏼👏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants