Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document -global- prefix for global CSS Animations #3352

Closed
dcrck opened this issue Aug 4, 2019 · 3 comments · Fixed by #4232
Closed

Document -global- prefix for global CSS Animations #3352

dcrck opened this issue Aug 4, 2019 · 3 comments · Fixed by #4232

Comments

@dcrck
Copy link

dcrck commented Aug 4, 2019

Hi,

When working with Google Maps, you create custom Markers with a createMarker function which takes in the marker's HTML as a string. That means if you want to apply styles or transitions to it, you need to use the :global tag in Svelte. I'd like to apply small animations to the markers on certain conditions, but it appears that I can't apply a CSS animation (e.g. @keyframes animation_name {...} in the Svelte component using the :global tag. When I tried, Svelte yelled at me with an Expected Identifier error.

I'd like this functionality to be enabled if possible. It's not super-critical since I can just put the css animation in my global.css file, and it's a very uncommon use case, but it would be nice 😄 .

@Conduitry
Copy link
Member

This was added way back in #607 by prefixing the animation name with -global- but it looks like this was never actually documented anywhere, beyond being linked from the changelog.

@Conduitry Conduitry added the docs label Aug 4, 2019
@dcrck
Copy link
Author

dcrck commented Aug 4, 2019

Cool, thanks! Should this issue stay open as a reminder to document? Otherwise, feel free to close.

@Conduitry
Copy link
Member

Yeah I gave this the 'docs' label because I want to use this to remind us to document it

@dcrck dcrck changed the title Support :global tag for CSS Animations Document -global- prefix for global CSS Animations Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants