-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nesting self-updating components. #263
Labels
Comments
I can try to fix it. But I'm not familiar with the internals. Any pointers where the issue lies? |
Rich-Harris
added a commit
that referenced
this issue
Jan 31, 2017
Rich-Harris
added a commit
that referenced
this issue
Jan 31, 2017
always flush render hooks, even if initiator is a nested component
Released 1.6.8 with the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've come across an issue, where onrender of a component isn't always called when it is being mounted.
I've created an example here.
It's got 3 components: Root -> List -> Item
List is being updated asynchronously. and it's adding some items to it's data.
The initial set of Items, from list is being rendered correctly. But the new elements rendered by the other values, are not being updated.
The problem lies in this generated code:
options._root
is the Root element. But that element is never updated, so it's_renderHooks
are never called.I can verify this by calling .set({}) on the root element.
The text was updated successfully, but these errors were encountered: