Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Dev runtime warning when passing unknown props #2174

Closed
Conduitry opened this issue Mar 7, 2019 · 4 comments · Fixed by #2881
Closed

Feature: Dev runtime warning when passing unknown props #2174

Conduitry opened this issue Mar 7, 2019 · 4 comments · Fixed by #2881
Labels
feature request

Comments

@Conduitry
Copy link
Member

When compiling with dev: true, a component should display a warning in the console when it is created with props with names it wasn't expecting.
@Conduitry Conduitry added this to the 3.x milestone Mar 7, 2019
@EmilTholin
Copy link
Member

Should we ignore trying to generate warnings for components that use $$props?

@colincasey colincasey mentioned this issue May 22, 2019
Merged
@Rich-Harris
Copy link
Member

Closed via #2840

@Rich-Harris
Copy link
Member

Though I've just realised that the PR doesn't address @EmilTholin's point about $$props, so I'll reopen it for now

@Rich-Harris Rich-Harris reopened this May 26, 2019
@Rich-Harris Rich-Harris mentioned this issue May 27, 2019
Merged
@nikse
Copy link

nikse commented Jul 26, 2020

I'm seeing lots of warnings when using $$restProps as well, should those also be silenced?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dont create unknown prop warnings for $$scope etc, or if component has $$props sveltejs/svelte
4 participants
@nikse @Rich-Harris @EmilTholin @Conduitry