Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle empty each blocks #1295

Merged
merged 1 commit into from
Mar 30, 2018
Merged

handle empty each blocks #1295

merged 1 commit into from
Mar 30, 2018

Conversation

Rich-Harris
Copy link
Member

Addendum to #1292. Edge case, but currently causes an error

@codecov-io
Copy link

codecov-io commented Mar 30, 2018

Codecov Report

Merging #1295 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1295      +/-   ##
==========================================
+ Coverage   91.66%   91.66%   +<.01%     
==========================================
  Files         122      122              
  Lines        4329     4330       +1     
  Branches     1365     1366       +1     
==========================================
+ Hits         3968     3969       +1     
  Misses        148      148              
  Partials      213      213
Impacted Files Coverage Δ
src/generators/nodes/EachBlock.ts 97.63% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77aca3c...50ed925. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 47da7d1 into master Mar 30, 2018
@Rich-Harris Rich-Harris deleted the each-block-keyed-empty branch March 30, 2018 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants