Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y: recognizing svg a links too #1008

Closed
paulocoghi opened this issue Dec 11, 2017 · 1 comment · Fixed by #1076
Closed

A11y: recognizing svg a links too #1008

paulocoghi opened this issue Dec 11, 2017 · 1 comment · Fixed by #1076

Comments

@paulocoghi
Copy link
Contributor

When using SVG elements, we need to use xlink:href attribute in anchors for greater compatibility (Safari doesn't work with just href):

<svg>
    <text><a xlink:href="/just_a_url">Just a text</a></text>
<svg>

But in this case, A11y inform this warning that isn't correct (since there is an anchor):

A11y: <a> element should have an href attribute

With time, I will try to submit a pull request, if you want :)

@Rich-Harris
Copy link
Member

A PR would be very welcome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants