diff --git a/src/generators/dom/visitors/Element/Binding.js b/src/generators/dom/visitors/Element/Binding.js index 2ca07f3f2e6d..83d415cb7455 100644 --- a/src/generators/dom/visitors/Element/Binding.js +++ b/src/generators/dom/visitors/Element/Binding.js @@ -30,7 +30,7 @@ export default function visitBinding ( generator, block, state, node, attribute // selected: b

diff --git a/test/runtime/samples/binding-select-initial-value/main.html b/test/runtime/samples/binding-select-initial-value/main.html index d7d02194c8da..ea154022401e 100644 --- a/test/runtime/samples/binding-select-initial-value/main.html +++ b/test/runtime/samples/binding-select-initial-value/main.html @@ -1,9 +1,9 @@

selected: {{selected}}

selected: {{selected}}

\ No newline at end of file diff --git a/test/runtime/samples/binding-select-multiple/_config.js b/test/runtime/samples/binding-select-multiple/_config.js index 89b0da96581f..ec4f3dfe4ec0 100644 --- a/test/runtime/samples/binding-select-multiple/_config.js +++ b/test/runtime/samples/binding-select-multiple/_config.js @@ -1,12 +1,12 @@ export default { - skip: true, // selectedOptions doesn't work in JSDOM??? + skip: true, // JSDOM data: { selected: [ 'two', 'three' ] }, html: ` - @@ -26,7 +26,7 @@ export default { assert.deepEqual( component.get( 'selected' ), [ 'three' ] ); assert.htmlEqual( target.innerHTML, ` - @@ -40,7 +40,7 @@ export default { assert.deepEqual( component.get( 'selected' ), [ 'one', 'three' ] ); assert.htmlEqual( target.innerHTML, ` - @@ -56,7 +56,7 @@ export default { assert.ok( !options[2].selected ); assert.htmlEqual( target.innerHTML, ` - diff --git a/test/runtime/samples/binding-select/_config.js b/test/runtime/samples/binding-select/_config.js index 85cf6e9e1a85..7fce00f327ad 100644 --- a/test/runtime/samples/binding-select/_config.js +++ b/test/runtime/samples/binding-select/_config.js @@ -1,6 +1,4 @@ export default { - skip: true, // selectedOptions doesn't work in JSDOM??? - html: `

selected: one

@@ -13,6 +11,10 @@ export default {

selected: one

`, + data: { + selected: 'one' + }, + test ( assert, component, target, window ) { const select = target.querySelector( 'select' ); const options = [ ...target.querySelectorAll( 'option' ) ]; diff --git a/test/runtime/samples/select-change-handler/_config.js b/test/runtime/samples/select-change-handler/_config.js index 560061a09cab..015c8182b41c 100644 --- a/test/runtime/samples/select-change-handler/_config.js +++ b/test/runtime/samples/select-change-handler/_config.js @@ -1,6 +1,4 @@ export default { - skip: true, // JSDOM - data: { options: [ { id: 'a' }, { id: 'b' }, { id: 'c' } ], selected: 'b' diff --git a/test/runtime/samples/select-one-way-bind-object/_config.js b/test/runtime/samples/select-one-way-bind-object/_config.js index 946eaabcebbe..0d7ddaccad7a 100644 --- a/test/runtime/samples/select-one-way-bind-object/_config.js +++ b/test/runtime/samples/select-one-way-bind-object/_config.js @@ -1,8 +1,6 @@ const items = [ {}, {} ]; export default { - skip: true, // JSDOM quirks - 'skip-ssr': true, data: {