fix: include method definitions in class private fields (#14365)

* fix: include method definitions in class private fields * Update packages/svelte/tests/runtime-runes/samples/class-disabinguate-private-method-definition/_config.js --------- Co-authored-by: Rich Harris <[email protected]>
sveltejs · Nov 19, 2024 · 32a1453 · 32a1453
1 parent ce47131
commit 32a1453
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 1 deletion.
diff --git a/.changeset/unlucky-icons-sit.md b/.changeset/unlucky-icons-sit.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: include method definitions in class private fields
diff --git a/packages/svelte/src/compiler/phases/3-transform/client/visitors/ClassBody.js b/packages/svelte/src/compiler/phases/3-transform/client/visitors/ClassBody.js
@@ -28,7 +28,7 @@ export function ClassBody(node, context) {
 
 	for (const definition of node.body) {
 		if (
-			definition.type === 'PropertyDefinition' &&
+			(definition.type === 'PropertyDefinition' || definition.type === 'MethodDefinition') &&
 			(definition.key.type === 'Identifier' ||
 				definition.key.type === 'PrivateIdentifier' ||
 				definition.key.type === 'Literal')

diff --git a/...velte/tests/runtime-runes/samples/class-disabinguate-private-method-definition/_config.js b/...velte/tests/runtime-runes/samples/class-disabinguate-private-method-definition/_config.js
@@ -0,0 +1,3 @@
+import { test } from '../../test';
+
+export default test({});
diff --git a/...elte/tests/runtime-runes/samples/class-disabinguate-private-method-definition/main.svelte b/...elte/tests/runtime-runes/samples/class-disabinguate-private-method-definition/main.svelte
@@ -0,0 +1,8 @@
+<script>
+	class Repo {
+	  tree = $state();
+	  async #tree() {
+	  }
+	}
+	const repo = new Repo();
+</script>
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		import { test } from '../../test';

		export default test({});