This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
a11y: remove tabindex and allow escaping codemirror #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dummdidumm
approved these changes
Jun 28, 2021
There was a problem hiding this comment.
Looks good to me. @pngwn might know more about the history of the visibility bug and why tabindex was positive. Only thing I can think of is that it should be focused directly when going to the repl page? Is that the case currently? If so, and if this is desirable for that page, it could become a prop.
|
I don't think having the positive tabindex is desirable on the REPL page either since it makes for a confusing tab order, though maybe someone has a different perspective. See also the reasons outlined by the Axe a11y tool. Thanks for the review! |
|
thank you! closing in favour of sveltejs/sites#122 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163
This PR makes some accessibility improvements to the REPL:
visibility: hiddento hide the output JS and CSS panels. Otherwise, they were receiving focus even when their corresponding tab was not selected. This caused focus to be lost when navigating with the keyboard. There was a 2-year-old comment saying thatvisibilitycouldn't be used due to a Chrome bug, but I didn't notice any weird behavior after applying my change. Maybe that bug isn't an issue in the latest Chrome? Let me know if I should find another way to approach the problem.I linked my local REPL with my local svelte.dev to test the changes and verified that keyboard navigation works as expected.