Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 5 (major release) planning #504

Closed
dummdidumm opened this issue Apr 14, 2022 · 3 comments · Fixed by #562
Closed

Version 5 (major release) planning #504

dummdidumm opened this issue Apr 14, 2022 · 3 comments · Fixed by #562
Assignees
Labels
next-major will be fixed in the next major

Comments

@dummdidumm
Copy link
Member

dummdidumm commented Apr 14, 2022

This issue is intended to collect breaking changes we want to do for the next major version of svelte-preprocess. What currently comes to my mind:

  • remove support for the default language (deprecated already)
  • remove support for lang="typescript" and type="text/..." (deprecated already AFAIK)
  • remove support for Node 10 (EOL) and 12 (EOL end of April)
  • remove peer dependencies and instead tell in the docs what versions we tested it with. Npm 7 automatically installs peer dependencies, which means useless downloads for almost everyone. UPDATE: There's https://docs.npmjs.com/cli/v8/configuring-npm/package-json#peerdependenciesmeta so we can keep peer deps. We can do this now already.
  • Only support the new SASS API (right now we only support the legacy API). This means bumping the peer dep.
@dummdidumm dummdidumm added the next-major will be fixed in the next major label Apr 14, 2022
@mcmxcdev
Copy link
Contributor

mcmxcdev commented May 6, 2022

You might want to add another bullet point to consider switching from yarn v1, which has frozen development for a while, to e.g. pnpm (which would be in line with the package manager choice of other sveltejs repos). That's not a semver issue though.

@kaisermann
Copy link
Member

This issue is intended to collect breaking changes we want to do for the next major version of svelte-preprocess. What currently comes to my mind:

I was hoping v5 would be released at a similar time as the RFCed new preprocess API, but it seems that's still far from happening. Removing deprecations and support for EOL node versions is a good start! We don't need to make it a very big breaking change 🤷

You might want to add another bullet point to consider switching from yarn v1, which has frozen development for a while, to e.g. pnpm (which would be in line with the package manager choice of other sveltejs repos).

I have no qualms with switching to another package manager, even more, if it's to the same one used by other Svelte projects.

@frangio
Copy link

frangio commented Jun 24, 2022

Peer dependencies can be marked optional as shown here: https://docs.npmjs.com/cli/v8/configuring-npm/package-json#peerdependenciesmeta

I believe this turns off the automatic installs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-major will be fixed in the next major
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants