Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Svelte 5 compatibility #88

Closed
rmunn opened this issue Dec 15, 2023 · 3 comments
Closed

Svelte 5 compatibility #88

rmunn opened this issue Dec 15, 2023 · 3 comments

Comments

@rmunn
Copy link

rmunn commented Dec 15, 2023

When creating a new Svelte project with pnpm create svelte and choosing Svelte 5, pnpm install warns about unmet peer dependencies. svelte-hmr lists dependencies on svelte@"^3.19.0 || ^4.0.0", but not Svelte 5.

If I ignore the error and proceed, everything seems to work as it should, but it would be nice if the svelte-hmr package explicitly listed Svelte 5 has a valid peer dependency.
@benmccann
Copy link
Member

This package will not add support for Svelte 5 because HMR will be built directly into Svelte 5

@dominikg
Copy link
Member

more info here #87

@dominikg dominikg closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2023
@rmunn
Copy link
Author

rmunn commented Dec 15, 2023

I searched through issues but forgot to search PRs. Thanks for the link to #87.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rmunn @benmccann @dominikg