Skip to content
This repository has been archived by the owner on Oct 13, 2022. It is now read-only.

Include storybook on default template #120

Closed
gustaYo opened this issue Mar 15, 2019 · 7 comments
Closed

Include storybook on default template #120

gustaYo opened this issue Mar 15, 2019 · 7 comments

Comments

@gustaYo
Copy link

gustaYo commented Mar 15, 2019

I just integrated storybook successfully with sapper. I think it should be included by default.
what are your thoughts?

I would be happy to make a PR

@arxpoetica
Copy link
Member

If you wanted to build it on a branch, it could live on a separate branch maybe, but it shouldn't be included as the main template. Sapper is unonpionanted when it comes to other frameworks / systems.

@Rich-Harris
Copy link
Member

To be fair, the default template does include Cypress, which is certainly an opinion. I'm not a Storybook user so don't have an opinion on whether it'd be good to include or not (it's possible that for something as opinionated as Sapper we should even consider building an alternative, I don't know), but the idea of making it easy to see/test/document individual components in a more interactive and visual way absolutely has merit.

@gustaYo Do you have a fork somewhere so we could see it in action?

@arxpoetica
Copy link
Member

@gustaYo
Copy link
Author

gustaYo commented Mar 30, 2019

@arxpoetica
Copy link
Member

This is really cool and maybe timely...I might use it on a current project...

@rixo
Copy link

rixo commented Apr 26, 2019

For reference, I've submitted a proposal for a more idiomatic support of Svelte v3 in Storybook. People interested in Svelte support in Storybook might want to chime in there: storybookjs/storybook#6653

@antony
Copy link
Member

antony commented Feb 15, 2020

I like storybook, and am a storybook user. But it is huge, has good, but incomplete support for Svelte, requires webpack, React, and a bunch of other dependencies, and is generally not a good fit for a Sapper template, whilst being an excellent fit for a styleguide or component library (but external to a project).

Going to close this issue on that basis (and the fact that nearly a year has passed), but happy for it to be re-opened if people feel strongly otherwise.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants