Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vscodeLanguageIds for vscode consumers, this includes coc-prettier #138

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Conversation

ryeballar
Copy link
Contributor

@ryeballar ryeballar commented Sep 8, 2020

coc-prettier relies on vscodeLanguageIds to identify a prettier plugin to perform automatic file format on specific triggers (e.g. format on file save). Source: https://github.com/neoclide/coc-prettier/blob/master/src/utils.ts#L68.

This property is also used across multiple official prettier plugins:

This property is also used in vscode-prettier: https://github.com/prettier/prettier-vscode/blob/main/src/LanguageResolver.ts#L37 .

Copy link
Contributor

@ehrencrona ehrencrona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@dummdidumm dummdidumm merged commit 4292131 into sveltejs:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants