Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no error when running svelte-check on invalid tsconfig.json #2154

Closed
DetachHead opened this issue Sep 11, 2023 · 0 comments
Closed

no error when running svelte-check on invalid tsconfig.json #2154

DetachHead opened this issue Sep 11, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@DetachHead
Copy link
Contributor

DetachHead commented Sep 11, 2023

Describe the bug

when your tsconfig.json is invalid, svelte-check does not complain

> tsc
tsconfig.json:12:47 - error TS6046: Argument for '--moduleResolution' option must be: 'node10', 'classic', 'node16', 'nodenext', 'bundler'.

12     "module": "NodeNext", "moduleResolution": "asdf"
                                                 ~~~~~~


Found 1 error in tsconfig.json:12

> svelte-check --tsconfig tsconfig.json

====================================
Loading svelte-check in workspace: c:\Users\user\Documents\my-app
Getting Svelte diagnostics...

====================================
svelte-check found 0 errors and 0 warnings

Reproduction

  1. put an invalid value in tsconfig.json, eg. "moduleResolution": "asdf"
  2. run svelte-check --tsconfig path/to/tsconfig.json

Expected behaviour

an error, like what tsc outputs:

tsconfig.json:12:47 - error TS6046: Argument for '--moduleResolution' option must be: 'node10', 'classic', 'node16', 'nodenext', 'bundler'.

12     "module": "NodeNext", "moduleResolution": "asdf"
                                                 ~~~~~~


Found 1 error in tsconfig.json:12

System Info

  • OS: windows 10

Which package is the issue about?

svelte-check

Additional Information, eg. Screenshots

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant