Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defensively handle omitted cache-control header in adapter-cloudflare #9884

Open
psytrx opened this issue May 9, 2023 · 0 comments
Open

defensively handle omitted cache-control header in adapter-cloudflare #9884

psytrx opened this issue May 9, 2023 · 0 comments
Labels
needs-decision Not sure if we want to do this yet, also design work needed pkg:adapter-cloudflare

Comments

@psytrx
Copy link
Contributor

psytrx commented May 9, 2023

Describe the problem

Introduced with #9768 , and already briefly discussed in a worktop issue.

A more defensive approach to caching may be reasonable because it may prevent bugs due to carelessness, and because we're relying on an external dependency here.

CC @0x221A

Describe the proposed solution

Re-introduce the check for an existing cache-control header

Alternatives considered

No response

Importance

would make my life easier

Additional Information

No response
@psytrx psytrx mentioned this issue May 9, 2023
Merged
5 tasks
@eltigerchino eltigerchino added pkg:adapter-cloudflare needs-decision Not sure if we want to do this yet, also design work needed labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-decision Not sure if we want to do this yet, also design work needed pkg:adapter-cloudflare
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@psytrx @eltigerchino