-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstate types #433
Comments
Most of the sub-packages are small enough that they can be build-free - though I think the main pain point with the TypeScript last time around was that we didn't have a CI setup, so people were constant breaking the configuration because they'd have previously built locally and didn't realize things were broken when they had files hanging around from their previous build. I expect that it'd be much more pain-free this time around now that we have a CI (plus I have fixed a couple bugs in |
How should typing of user-written functions like However, if the |
Types should definitely be generated or at least written by hand and provided as is so that people can use TS in their projects with ease. Using JsDoc in Kit should not harm the UX for devs using Kit with TS. |
The really nice thing about 'build free' is that it's really 'build optional'. Kit is built, because it results in a faster installation and startup (the latter of which is particularly crucial for a CLI) but the trade-off is that developing Kit itself is significantly more complex. If it was possible for |
Closing as this is basically done, except in the adapters, which is dependent on a resolution of #439 |
Now that things are settling down and we're nearing a public beta, I think it's worth getting types back in the project. I've been spoiled by build-free JSDoc types and strongly believe that's the right approach for this repo (or at least, most packages in this repo) so I think we should see how far we get with that
The text was updated successfully, but these errors were encountered: