-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hero images to kit.svelte.dev #244
Comments
OK, |
These are looking better and better! I was able to add a comment |
Great, then just comment if you have further need for action, criticism or suggestions for improvement. |
I'm wondering where to integrate these. One idea would be in the three boxes on the SvelteKit homepage. "Powered by Svelte" could be the power plant looking thing, "Best of both worlds" could be the two streams colliding, "Build fast" could be the factory pumping out machines from boxes. Maybe the background of those three sections would change to the image when hovered over |
Yes, when I made them I didn't know that SvelteKit would get its own site. IMO the illus are rather meant as a replacement for the relatively simple outline-S. Large background images as eyecandy (see figma-layout). One for Svelte itself and one for SvelteKit. As a result, the SvelteKit site is then also visually more distinct from the Svelte site. I think degrading them into the three boxes would make them very small-scale and petty after all. [edit] |
100%, definitely hero images. I absolutely love these mockups and can't wait for us to start implementing them |
Oh, nice! Yeah, much better usage to have them more prominent! I just sort of thought it was funny how well the images matched the captions for the boxes and wasn't sure how to blend the backgrounds, but the Figma mockups look much better than what I suggested 😄 |
@vedam Actually is already public |
@zamkevich Thx for enlightening me. |
I'd like to be able to see the files. |
I have no issues with the files being public. It's up to @vedam whether he wants to be getting comments on them or not 😁 Anyway, the most interesting ones are already included in the description of this issue |
What is the license for these? Can we use them when promoting Svelte to the general public? |
OK then, if public viewing isn't a concern: reopened to view for everyone. ;-) |
Just seen these - really awesome work. |
Making a note here for anyone that would want to work on this. The code lives in https://github.com/sveltejs/sites/tree/master/sites/kit.svelte.dev |
I just created the first PR related to it: sveltejs/sites#17. It's updating the existing components to match with the new design (adding the new hero image) -- I'll create a new PR in order to add the new sections soon :) CC: @benmccann |
Includes #33, #34, #168, but I mostly wanted to raise this catch-all issue so we have a convenient place for @vedam's gorgeous work: https://www.figma.com/file/f87psJnCeqMbUPAQABmCrN/svelte
The text was updated successfully, but these errors were encountered: