Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop versions of Node before 18.13 #10527

Closed
benmccann opened this issue Aug 10, 2023 · 0 comments
Closed

Drop versions of Node before 18.13 #10527

benmccann opened this issue Aug 10, 2023 · 0 comments
Labels
breaking change
Milestone
2.0

Comments

@benmccann
Copy link
Member

benmccann commented Aug 10, 2023 •
edited
Loading

Describe the problem

#8991 (comment)

kit/packages/kit/src/exports/node/polyfills.js

Line 24 in bfa2b6e

// TODO: remove this once we only support Node 18.11+ (the version multipart/form-data was added)

Describe the proposed solution

bump the engines field, conditionally polyfill as proposed in #10273, then remove polyfill option from adapter-node: https://kit.svelte.dev/docs/adapter-node#options-polyfill

I'm not exactly sure when globalThis.crypto was made available, but I think crypto may need to be polyfilled until Node 20

Alternatives considered

No response

Importance

nice to have

Additional Information

No response
@benmccann benmccann added this to the 2.0 milestone Aug 10, 2023
@benmccann benmccann mentioned this issue Aug 10, 2023
Closed
5 tasks
@benmccann benmccann mentioned this issue Dec 2, 2023
Merged
@benmccann benmccann changed the title Drop versions of Node before 18.11 Drop versions of Node before 18.13 Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@benmccann