Porting some svelte rules I've made elsewhere?

[tivac]

Motivation

I've got a collection of custom eslint rules for svelte that I've been iterating on for a while. Now that this package exists (and is excellent!) I'm curious if you'd be interested in PRs to migrate some or all of these rules into this package?

https://github.com/tivac/eslint-plugin-svelte

Description

• add svelte/no-extra-reactive-curlies rule #201
• Add svelte/no-reactive-literals rule #203
• Add prefer-reactive-destructuring rule #205
• add no-reactive-functions rule #206
• Add prefer-destructured-store-props rule #208
• feat: implement derived-has-same-inputs-outputs #249
• Add svelte/require-stores-init rule #211
• feat: implement stores-no-async #225

Examples

Examples for all of the rules are available in the tests folder.

Additional comments

No response

[ota-meshi]

That's great for me!!

Are you planning to deprecate @tivac/eslint-plugin-svelte after migrating those rules? If so, I have one concern.
eslint-plugin-svelte cannot be used with eslint-plugin-svelte3.
@tivac/eslint-plugin-svelte can be used with both eslint-plugin-svelte3 or eslint-plugin-svelte.
If we deprecate @tivac/eslint-plugin-svelte, it means that those rules cannot be used with eslint-plugin-svelte3.

[ota-meshi]

By the way, I don't use eslint-plugin-svelte3, so it's perfectly fine for me.

[JounQin]

I won't consider eslint-plugin-svelte3 at all personally, it's just full of hacking and unusable for a lot of cases.

Besides, I've already encouraged users to use this plugin instead at https://github.com/prettier/eslint-plugin-prettier#svelte-support and also sveltejs/eslint-plugin-svelte3#184.

[tivac]

Oh great, I'll try to get cracking on some PRs then.

I haven't had a ton of issues with eslint-plugin-svelte3 before but I also see zero reason to use it when this project exists and works great. I will probably remove all of the reactive statement rules from my package I guess? Since the store-focused rules can be used on both .svelte and .js files I don't know exactly how they'd fit into this package, curious if you have any thoughts there @ota-meshi :)

[ota-meshi]

I think it's okay that the plugin contains rules that can also be used with *.js.

However, maybe something needs to be done to get the demo for *.js to work on the documentation site.

[baseballyama]

Thank you for following up on the issue @ota-meshi and @tivac .
Can we close this issue? (I don't have such an ability.)

[ota-meshi]

Yeah, thanks to your help, all the rules have been implemented! So I close this issue.