Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lots of PR out of sync #465

Closed
MacFJA opened this issue Sep 30, 2023 · 2 comments
Closed

Lots of PR out of sync #465

MacFJA opened this issue Sep 30, 2023 · 2 comments

Comments

@MacFJA
Copy link
Collaborator

MacFJA commented Sep 30, 2023 •
edited
Loading

  • Lots of PRs are in conflict and need to be rebased
  • Lots of PRs have code style issue

What should we do ?

  • Close all PRs in those that have more than X days ?
  • Add a comment on all PRs to ask the author to update them ?
  • Should I fix all of them ?

I'm not for fixing all PRs, I fear that people will not do any effort in the future as "eventually, someone will fix my PR"

Should we remove the prettier check on components.json, tools.json, templates.json ?
Because it appears quite clearly that submitters don't install the repo (because husky is installed, and it runs automatically prettier before committing) nor run prettier manually

Your thoughts on this @benmccann @kevmodrome
@benmccann
Copy link
Collaborator

My thought was that if we first simplified the process of submitting libraries by automating more stuff (#443) then it wouldn't be so hard to just submit the libraries from the PRs ourselves

@MacFJA
Copy link
Collaborator Author

MacFJA commented Dec 16, 2023

I guess @lachlancollins is doing it anyway

@MacFJA MacFJA closed this as completed Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benmccann @MacFJA