Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert CRLF for script bin files #314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lilyinstarlight
Copy link
Contributor

After we started generating our own bin links in #302, we did not provide the line-ending normalization that npm did

This PR corrects that to have similar behavior to before for packages with CRLF line-endings

nix/node-env.nix Outdated Show resolved Hide resolved
@lilyinstarlight lilyinstarlight changed the title Apply dos2unix to script bin files Convert CRLF for script bin files Mar 6, 2023
After we started generating our own bin links, we did not provide the
line-ending normalization that npm did. This corrects that to have
similar behavior to before for packages with CRLF line-endings.

This also has a drive-by change to remove the unnecessary
`patchShebangs` due to the `patchShebangsAuto` hook running and finding
these files just fine now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants