support SHA256 hashes #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still have not seen any SHA256 examples myself. Furthermore, for SHA256 it uses Nix's own notation, that most likely is not compatible. Have you also checked whether you could deploy a package with a SHA256 or provide me an example of such a package? |
jacereda
reviewed
Mar 19, 2019
| @@ -171,6 +171,8 @@ NPMRegistrySource.prototype.toNixAST = function() { | |||
| case "sha1": | |||
| paramExpr.sha1 = this.sha1; | |||
| break; | |||
| case "sha256": | |||
| paramExpr.sha256 = this.sha256; | |||
There was a problem hiding this comment.
Looks like you forgot a break there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across an registry implementation which uses these.