Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround for strict not failing when using RENOVATE_CONFIG_FILE #770

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

pippitt
Copy link
Contributor

@pippitt pippitt commented Nov 26, 2024

Related to #768
Verified strict now exits with a non-zero code so the action will fail if there is a migration.
The quoting was giving me issues so I changed it (verified with shellcheck).
Not sure about my change on the logic on when config files are passed or not, seemed like if one is passed the usual location could be skipped, but maybe that was intentional.

@suzuki-shunsuke
Copy link
Owner

Thank you for your contribution!

@suzuki-shunsuke suzuki-shunsuke added this to the v1.1.1 milestone Nov 27, 2024
@suzuki-shunsuke suzuki-shunsuke merged commit 916714d into suzuki-shunsuke:main Nov 27, 2024
1 check passed
@suzuki-shunsuke
Copy link
Owner

📝

I didn't know that renovate-config-validator can accept configuration files via positional arguments.

This accepts multiple files, meaning we don't need to use for loop in shell script to validate multiple files.
I'll fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants