Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't treat strings as objects #172

Merged
merged 1 commit into from
Dec 22, 2020
Merged

fix: don't treat strings as objects #172

merged 1 commit into from
Dec 22, 2020

Conversation

just-jeb
Copy link
Contributor

Closes #170

@just-jeb just-jeb mentioned this pull request Dec 22, 2020
Closed
@bebraw bebraw merged commit 4356dcd into survivejs:develop Dec 22, 2020
@bebraw
Copy link
Member

bebraw commented Dec 22, 2020

Thanks a lot. Included in 5.7.3.

This was referenced Mar 11, 2021
Closed
Closed
Closed
Closed
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Closed
Tstaggers18
Tstaggers18 reviewed Jun 7, 2024
View reviewed changes
Copy link

@Tstaggers18 Tstaggers18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tstaggers18 Tstaggers18 Tstaggers18 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] mergeWithRules alters a string in the original config
3 participants
@just-jeb @bebraw @Tstaggers18