-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Having issues while updating from 4.2.2 to 5.1.4 #148
Comments
Hi, Can you send me a simple example (two minimal configurations + output after merge) to help developing this feature? Is the idea to match based on I've been exploring a light solution related to this at issue 146. The use case is far more complex there but it's possible what you have here would fit into the problem. |
@ioanungurean I added a new API called mergeWithRules. Can you check if it would work for your use case? |
Having the same problem. Going to stay at v 4.2.2. |
Can you open a separate issue with your current setup? Ideally it should be simplified as much as possible and something I can run.
… On 11.10.2020, at 17:31, Eugen Mayer ***@***.***> wrote:
Having the same problem. mergeWithRules didn't help.
Going to stay at v 4.2.2.
link to repo
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@ioiooi Ah, nevermind. Just saw your link a second too late. I'll check how it would work with v5. |
@ioiooi If you want to use v5, it looks like the following is a good option in your case: const common = require('./webpack.common.js');
const { mergeWithCustomize, customizeArray } = require('webpack-merge');
const webpack = require('webpack');
const MiniCssExtractPlugin = require('mini-css-extract-plugin');
module.exports = mergeWithCustomize({
customizeArray: customizeArray({
'module.rules': 'prepend'
}),
})(common, {...}) I noticed |
@bebraw sorry, for not isolating the issue and making it harder for you to work with. Your suggestion works! Thank you! 👍 |
@ioiooi No worries, it was easy enough to work against your repository. Have a nice week. 👍 |
I'm closing this one. Feel free to open a new issue if the new API doesn't work for your use case. |
Hi, as I did not see an upgrade guide I willl post it here. I was using the
smartStartegy
before and I tried to use the new API but for some reason the merge is not happening as before.Is the code below equivalent to the one above? What am I doing wrong?
Here is a link to the repo if that helps.
Thank you in advance for looking over my issue. And I appologise if this is not the right place to post this issue.
The text was updated successfully, but these errors were encountered: