From a64c980b3fa11b9e95b2d0c0c809e105f51d2dd1 Mon Sep 17 00:00:00 2001 From: Dmitry Kurmanov Date: Fri, 6 Oct 2023 18:16:33 +0400 Subject: [PATCH] work for the https://github.com/surveyjs/survey-library/issues/7071 (#7091) --- .../src/components/dropdown/dropdown.component.html | 1 - .../components/tagbox/tagbox-filter.component.html | 1 - .../src/components/dropdown/Dropdown.vue | 1 - .../src/components/tagbox/TagboxFilter.vue | 1 - src/knockout/components/dropdown/dropdown.html | 3 +-- src/knockout/components/tagbox/tagbox.html | 1 - src/react/dropdown-base.tsx | 1 - src/react/tagbox-filter.tsx | 1 - src/vue/components/dropdown/dropdown.vue | 1 - src/vue/components/tagbox/tagbox-filter.vue | 1 - .../snapshots/dropdown-aria-expanded.snap.html | 2 +- .../markup/snapshots/dropdown-input-string.snap.html | 2 +- .../snapshots/dropdown-select-clear-button.snap.html | 2 +- .../snapshots/dropdown-select-mobile.snap.html | 2 +- tests/markup/snapshots/dropdown-select.snap.html | 2 +- .../snapshots/dropdown-with-markdown.snap.html | 2 +- .../snapshots/dropdown-with-none-value.snap.html | 2 +- .../snapshots/dropdown-with-other-value.snap.html | 2 +- .../markup/snapshots/matrixdynamic-default.snap.html | 12 ++++++------ .../snapshots/matrixdynamic-defaultV2.snap.html | 12 ++++++------ .../rating-as-dropdown-with-value-focused.snap.html | 2 +- tests/markup/snapshots/rating-as-dropdown.snap.html | 2 +- tests/markup/snapshots/tagbox-mobile.snap.html | 2 +- tests/markup/snapshots/tagbox-selected.snap.html | 2 +- .../snapshots/tagbox-without-clear-button.snap.html | 2 +- .../markup/snapshots/tagbox-without-search.snap.html | 2 +- tests/markup/snapshots/tagbox.snap.html | 2 +- 27 files changed, 28 insertions(+), 38 deletions(-) diff --git a/packages/survey-angular-ui/src/components/dropdown/dropdown.component.html b/packages/survey-angular-ui/src/components/dropdown/dropdown.component.html index 976e65c211..c811c5d9b4 100644 --- a/packages/survey-angular-ui/src/components/dropdown/dropdown.component.html +++ b/packages/survey-angular-ui/src/components/dropdown/dropdown.component.html @@ -25,7 +25,6 @@ [attr.inputmode]="dropdownModel.inputMode" [attr.tabindex]="dropdownModel.inputReadOnly ? null : -1" [attr.disabled]="model.isInputReadOnly ? true : null" - [attr.aria-label]="model.placeholder" [attr.aria-controls]="dropdownModel.listElementId" [attr.aria-expanded]="model.ariaExpanded" [attr.aria-activedescendant]="dropdownModel.ariaActivedescendant" diff --git a/packages/survey-angular-ui/src/components/tagbox/tagbox-filter.component.html b/packages/survey-angular-ui/src/components/tagbox/tagbox-filter.component.html index 1930902b6f..bbee07ced6 100644 --- a/packages/survey-angular-ui/src/components/tagbox/tagbox-filter.component.html +++ b/packages/survey-angular-ui/src/components/tagbox/tagbox-filter.component.html @@ -19,7 +19,6 @@ [attr.readonly]="!model.searchEnabled ? true : null" [attr.disabled]="question.isInputReadOnly ? true : null" [attr.size]="!model.inputStringRendered ? 1 : null" - [attr.aria-label]="question.placeholder" [attr.aria-controls]="model.listElementId" [attr.aria-expanded]="question.ariaExpanded" [attr.aria-activedescendant]="model.ariaActivedescendant" diff --git a/packages/survey-vue3-ui/src/components/dropdown/Dropdown.vue b/packages/survey-vue3-ui/src/components/dropdown/Dropdown.vue index 8f59502860..f26a6f91b5 100644 --- a/packages/survey-vue3-ui/src/components/dropdown/Dropdown.vue +++ b/packages/survey-vue3-ui/src/components/dropdown/Dropdown.vue @@ -58,7 +58,6 @@ :id="question.getInputId()" :tabindex="model.inputReadOnly ? undefined : -1" :readonly="!model.searchEnabled ? true : undefined" - :aria-label="question.placeholder" :aria-expanded=" question.ariaExpanded === null ? undefined diff --git a/packages/survey-vue3-ui/src/components/tagbox/TagboxFilter.vue b/packages/survey-vue3-ui/src/components/tagbox/TagboxFilter.vue index e4c0eaf55d..dab875b943 100644 --- a/packages/survey-vue3-ui/src/components/tagbox/TagboxFilter.vue +++ b/packages/survey-vue3-ui/src/components/tagbox/TagboxFilter.vue @@ -22,7 +22,6 @@ :disabled="question.isInputReadOnly" :inputmode="model.inputMode" :role="model.filterStringEnabled ? question.ariaRole : undefined" - :aria-label="question.placeholder" :aria-expanded=" question.ariaExpanded === null ? undefined diff --git a/src/knockout/components/dropdown/dropdown.html b/src/knockout/components/dropdown/dropdown.html index ad46159ffc..8293c0efcd 100644 --- a/src/knockout/components/dropdown/dropdown.html +++ b/src/knockout/components/dropdown/dropdown.html @@ -39,8 +39,7 @@
- +
- +