Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Select Matrix: Input mask is reverted to its previous value in the UI #4690

Closed
ale-x-may opened this issue Oct 5, 2023 · 5 comments
Closed
Assignees
Labels
bug user issue An issue or bug reported by users.
Milestone

Comments

@ale-x-may
Copy link

ale-x-may commented Oct 5, 2023

Hello,

using the third-party Robin Herbots Inputmask plugin it is possible to mask input fields of text and multipletext questions. In addition to this, we also need that functionality for matrix questions, i.e. for columns ("matrixdropdowncolumn") of textual input. Since the inputMask property appears for all columns by default, but only works for textual inputs, I adapted the properties' visibleIf to the effect that inputMask is only shown for columns of cellType "text" and inputType "text" (see currency column below):

matrix-inputMask

Luckily it works all fine in the Preview:

matrix-inputMask-input

But the problem is that after refreshing the page the inputMask field in the Creator always shows the defaultValue ("none") instead of "currency" as stored in the JSON:

Screenshot 2023-10-05 114355

matrix-inputMask-json

Regardless of that buggy behaviour the masking functionality in the Preview still works correctly. Perhaps the mapping of JSON value to the corresponding property does not work for matrixdropdowncolumn yet?

Thanks for your reply.

@ale-x-may ale-x-may changed the title Provide proper Inputmask support for columns of matrix questions Provide proper Inputmask support for text columns of matrix questions Oct 5, 2023
@JaneSjs JaneSjs self-assigned this Oct 5, 2023
@JaneSjs JaneSjs added question user issue An issue or bug reported by users. labels Oct 5, 2023
@JaneSjs
Copy link
Contributor

JaneSjs commented Oct 5, 2023

Hello,
I created the following demo for your reference: View CodeSandbox. If you load a creator, you can see that the specified input mask is correctly applied.

Please let me know if this example helps.

@ale-x-may
Copy link
Author

Thanks. I realized that I used an older version. Using a newer one solved that problem.

@ale-x-may
Copy link
Author

Hello,
now I encountered another problem: changing inputMask of Column 1, e.g. from "currency" to "datetime", leads to correctly updating the JSON but when afterwards clicking a few times around in the UI and then looking at the inputMask field in the Creator again, the old value is displayed ("currency") instead of the new one ("datetime"), although the JSON still holds the correct value ("inputMask": "datetime") and the bahavior in the Preview is also as expected. This also applies to your created demo.

I'm looking forward to your reply.

@JaneSjs
Copy link
Contributor

JaneSjs commented Nov 21, 2023

Hello @ale-x-may,
Thank you for reporting this issue. I reproduced it on a CodeSandbox I recently shared. We will investigate this issue and update you as soon as we get any news to share.

2023-11-21_18-48-23.mp4

Thanks

@JaneSjs JaneSjs added bug and removed question labels Nov 21, 2023
@JaneSjs JaneSjs changed the title Provide proper Inputmask support for text columns of matrix questions Multi-Selection Matrix - Inputmask is reverted to its previous value in UI Nov 21, 2023
@JaneSjs JaneSjs assigned andrewtelnov and unassigned JaneSjs Nov 22, 2023
@andrewtelnov
Copy link
Member

@ale-x-may This commit fix this issue. Properties are shown in the column object and not in the column list.

Thank you,
Andrew

@RomanTsukanov RomanTsukanov changed the title Multi-Selection Matrix - Inputmask is reverted to its previous value in UI Multi-Select Matrix: Input mask is reverted to its previous value in the UI Nov 28, 2023
@OlgaLarina OlgaLarina added this to the v1.9.119 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug user issue An issue or bug reported by users.
Projects
None yet
Development

No branches or pull requests

4 participants