Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(XT 1.1) Fix various typos #5795

Merged
merged 4 commits into from
Jan 22, 2022
Merged

(XT 1.1) Fix various typos #5795

merged 4 commits into from
Jan 22, 2022

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Jan 19, 2022

Found via codespell -q 3 -S ./libs -L adres,applys,nd,olt,ontext,pard,parm,ro,ser,tbe,te,whichs,wth

Found via `codespell -q 3 -S ./libs -L adres,applys,nd,olt,ontext,pard,parm,ro,ser,tbe,te,whichs,wth`
@mkruselj
Copy link
Collaborator

mkruselj commented Jan 19, 2022

@luzpaz We cannot accept this PR unless all affected files are clang formatted. You can see it fails the code quality check.

@baconpaul baconpaul changed the title Fix various typos (XT 1.1) Fix various typos Jan 19, 2022
@baconpaul
Copy link
Collaborator

Great thanks @luzpaz - we will do a review and merge into our next release.

Is codespell something we could run in our CI pipeline? I see you are a contributor to the project.

@luzpaz
Copy link
Contributor Author

luzpaz commented Jan 19, 2022

@baconpaul
Copy link
Collaborator

Great! We are on azure (we automated our GitHub before actions!) but i'm sure I can figure it out. I'll add an issue.

@baconpaul baconpaul merged commit 78210b5 into surge-synthesizer:main Jan 22, 2022
@luzpaz luzpaz deleted the typos branch January 22, 2022 14:02
baconpaul added a commit to baconpaul/surge that referenced this pull request Jan 28, 2022
Revert this commit to return to the 1.1 pipeline

Revert "Linux pluginsonly should be .tar.gz (surge-synthesizer#5832)"
This reverts commit edbf08a.

Revert "CLAP enable Surge by default (surge-synthesizer#5831)"
This reverts commit b75ca09.

Revert "Move path to shared sst-plugininfra (surge-synthesizer#5826)"
This reverts commit cb81930.

Revert "(XT 1.1) Fix various typos (surge-synthesizer#5795)"
This reverts commit 78210b5.

Revert "Move Surge XT to sst-plugininfra for TinyXML; FS (surge-synthesizer#5799)"
This reverts commit a06f419.

Revert "Handle StrNat Internal Spaces Differently (surge-synthesizer#5791)"
This reverts commit 6b42b59.

Revert "Add options for scene highpass slopes up to 48 dB/oct (surge-synthesizer#5762)"
This reverts commit 23e5b92.

Revert "(XT 1.1) Make certain osc controls semitransparent for Audio In (surge-synthesizer#5766)"
This reverts commit 3805547.

Revert "(XT 1.1) Move version to 1.1.0 (surge-synthesizer#5800)"
This reverts commit 2cb16c8.
baconpaul added a commit that referenced this pull request Jan 28, 2022
Revert this commit to return to the 1.1 pipeline

Revert "Linux pluginsonly should be .tar.gz (#5832)"
This reverts commit edbf08a.

Revert "CLAP enable Surge by default (#5831)"
This reverts commit b75ca09.

Revert "Move path to shared sst-plugininfra (#5826)"
This reverts commit cb81930.

Revert "(XT 1.1) Fix various typos (#5795)"
This reverts commit 78210b5.

Revert "Move Surge XT to sst-plugininfra for TinyXML; FS (#5799)"
This reverts commit a06f419.

Revert "Handle StrNat Internal Spaces Differently (#5791)"
This reverts commit 6b42b59.

Revert "Add options for scene highpass slopes up to 48 dB/oct (#5762)"
This reverts commit 23e5b92.

Revert "(XT 1.1) Make certain osc controls semitransparent for Audio In (#5766)"
This reverts commit 3805547.

Revert "(XT 1.1) Move version to 1.1.0 (#5800)"
This reverts commit 2cb16c8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants