Channel sustain pedal

[baconpaul]

Yeah

surge/src/common/SurgeSynthesizer.cpp

Line 2100 in 448b4ef

sustainpedalCC = value;

the channel hold only applies to the channel with the sustain pedal. That’s an oddity in all our modes. There’s special mpe treatment elsewhere but you aren’t in mpe mode. I’ll open an issue

In octave per channel mode sustain pedal is channel limited basically

Discord user conradtao

[mkruselj]

Right, so the solution is to accept sustain pedal as omni in channel per octave mode.

[baconpaul]

Yeah exactly

and I should re test mpe

and we should think about 2/3 mode also

[mkruselj]

I'd say let's keep that mode for 1.x and axe it in XT2.

[baconpaul]

Yeah agree. or perhaps have a better midi control overall. Like if a scene has a midi filter etc then it’s not hardwired and mysterious

if we write arpeggiators and chord modes we are messing with the front of the note stack anyway so it’s a good opportunity

but that’s not this issue! And not this year :)

[mkruselj]

To me, a more elaborate MIDI channel handling only has merit if we resuscitate the old "more than two scenes" feature request. 🙂

Also, we can basically duplicate the current ch23 scheme by setting the scene mode to channel split, and set channel 3 as split point, giving all the more reason to axe the hard-coded behavior...

[baconpaul]

oh yeah excellent points all!

[mkruselj]

Hell, maybe we should axe this behavior for 1.3 already? Although I can imagine some projects relying on this behavior... maybe we could detect events being received from ch2/3 if MPE is not enabled then throw a dialog to then automatically set channel split accordingly?

[baconpaul]

Nah it works and we have an option. More trouble to axe it than leave it