Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XT2 Latch AEG behavior #6964

Open
Andreya-Autumn opened this issue Apr 20, 2023 · 1 comment
Open

XT2 Latch AEG behavior #6964

Andreya-Autumn opened this issue Apr 20, 2023 · 1 comment
Labels
Breaking Change In order to close this issue we need to make a breaking change (no backwards compatibility) DSP Issues and feature requests related to sound generation in the synth Modulation Modulation related issues
Milestone
Surge XT 2.0

Comments

@Andreya-Autumn
Copy link
Collaborator

Andreya-Autumn commented Apr 20, 2023 •
edited
Loading

Latch reset AEGs from zero and should probably just always reset from current.

More accurately, it will do whatever was last selected under the mono modes, but those options don't show up with latch selected, which is very counterintuitive.
@Andreya-Autumn Andreya-Autumn added DSP Issues and feature requests related to sound generation in the synth UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. labels Apr 20, 2023
@mkruselj mkruselj added Modulation Modulation related issues and removed UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. labels Apr 21, 2023
@mkruselj mkruselj modified the milestones: Surge XT 1.x, Surge XT 1.3 Apr 21, 2023
@mkruselj mkruselj mentioned this issue Apr 21, 2023
Merged
@mkruselj
Copy link
Collaborator

mkruselj commented May 1, 2023 •
edited
Loading

These are now options for Latch mode, but in XT2 we should just make latch continue from current value always, making it a breaking change.

@mkruselj mkruselj added the Breaking Change In order to close this issue we need to make a breaking change (no backwards compatibility) label May 1, 2023
@mkruselj mkruselj modified the milestones: Surge XT 1.3, Surge XT 2.0 May 1, 2023
@Andreya-Autumn Andreya-Autumn changed the title Latch resets AEG from zero XT2 Latch AEG behavior Aug 12, 2023
This was referenced Mar 5, 2024
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking Change In order to close this issue we need to make a breaking change (no backwards compatibility) DSP Issues and feature requests related to sound generation in the synth Modulation Modulation related issues
Projects
None yet
Milestone
Surge XT 2.0
Development

No branches or pull requests
2 participants
@mkruselj @Andreya-Autumn